Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set the executable name separate from the app name #758

Merged
merged 1 commit into from Nov 20, 2017

Conversation

malept
Copy link
Member

@malept malept commented Nov 20, 2017

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Adds the executableName option (--executable-name in CLI) which allows to set the executable name, which defaults to name but does not affect the .app name.

Example:

const packager = require('electron-packager')

packager({
  name: 'App Name',
  executableName: 'app-name',
  platform: 'all'
})

On Windows, the Electron binary will be app-name.exe. On Linux, the Electron binary will be app-name. On macOS, the app is App Name.app and the binary inside it is App Name.app/Contents/MacOS/app-name.


Fixes #745.

Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit 👍

@malept malept merged commit 31e1e98 into master Nov 20, 2017
@malept malept deleted the custom-executable-name branch November 20, 2017 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants