Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mz dependencies #759

Merged
merged 1 commit into from Nov 20, 2017
Merged

fix mz dependencies #759

merged 1 commit into from Nov 20, 2017

Conversation

mironal
Copy link
Contributor

@mironal mironal commented Nov 20, 2017

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

I got an error Cannot find module 'mz/child_process' with electron-packager v10.0.0.

I found mz/child_process to be used in following code.

https://github.com/electron-userland/electron-packager/blob/2a9374e027494d97a984b469c7540cf501be2a08/prune.js#L3

And I moved mz from devDependencies to dependencies in package.json.

@welcome
Copy link

welcome bot commented Nov 20, 2017

Thanks for opening a pull request!

Here are some highlighted action items that will help get it across the finish line, from the
pull request guidelines:

  • Follow the JavaScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes in NEWS.md and other docs.
  • Include tests when adding/changing behavior.

Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.

@malept
Copy link
Member

malept commented Nov 20, 2017

Thanks for catching that. In the future, it would be nice if the summary was filled in so it's more obvious why the changes are warranted.

@malept malept merged commit 05ba8a9 into electron:master Nov 20, 2017
@welcome
Copy link

welcome bot commented Nov 20, 2017

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants