Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ARM detection on armv7l Node #783

Merged
merged 1 commit into from Jan 2, 2018
Merged

Fix ARM detection on armv7l Node #783

merged 1 commit into from Jan 2, 2018

Conversation

malept
Copy link
Member

@malept malept commented Jan 1, 2018

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Several versions of Node for armv7l incorrectly identify as arm_version: '6'.

See: nodejs/node#4531 and related.

@malept malept added bug 🐛 build-target:linux 🐧 Bundling an Electron app specifically for Linux labels Jan 1, 2018
Several versions of Node for armv7l incorrectly identify as
`arm_version: '6'`.

See: nodejs/node#4531 and related
@malept malept merged commit e8e7ed3 into master Jan 2, 2018
@malept malept deleted the fix-arm-hostarch branch January 2, 2018 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 build-target:linux 🐧 Bundling an Electron app specifically for Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant