Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for official MIPS64EL arch on Linux #800

Merged
merged 2 commits into from Feb 7, 2018
Merged

Conversation

malept
Copy link
Member

@malept malept commented Feb 7, 2018

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This arch is available with official Electron releases starting with Electron 1.8.2-beta.5.

This is a breaking change, since the behavior of the all option changes.

@codecov
Copy link

codecov bot commented Feb 7, 2018

Codecov Report

Merging #800 into master will increase coverage by 5.05%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #800      +/-   ##
========================================
+ Coverage   94.94%   100%   +5.05%     
========================================
  Files          11     11              
  Lines         574    579       +5     
========================================
+ Hits          545    579      +34     
+ Misses         29      0      -29
Impacted Files Coverage Δ
targets.js 100% <100%> (ø) ⬆️
ignore.js 100% <0%> (+2.63%) ⬆️
mac.js 100% <0%> (+23.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f09ac9e...b6e4082. Read the comment docs.

@malept malept merged commit aacf297 into master Feb 7, 2018
@malept malept deleted the mips64el-support branch February 7, 2018 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant