Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rcedit to 1.0.0 #804

Merged
merged 1 commit into from Feb 13, 2018
Merged

Upgrade rcedit to 1.0.0 #804

merged 1 commit into from Feb 13, 2018

Conversation

malept
Copy link
Member

@malept malept commented Feb 13, 2018

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This should fix the "Unable to set icon" problems people were reporting previously. (Does not necessarily mean that future instances of this error will be fixed by it.)

@codecov
Copy link

codecov bot commented Feb 13, 2018

Codecov Report

Merging #804 into master will decrease coverage by 5%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #804      +/-   ##
==========================================
- Coverage     100%   94.99%   -5.01%     
==========================================
  Files          11       11              
  Lines         579      579              
==========================================
- Hits          579      550      -29     
- Misses          0       29      +29
Impacted Files Coverage Δ
mac.js 76.27% <0%> (-23.73%) ⬇️
ignore.js 97.36% <0%> (-2.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68c99e2...1b39cd7. Read the comment docs.

@malept malept merged commit 197ab5c into master Feb 13, 2018
@malept malept deleted the rcedit-1.0.0 branch February 13, 2018 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant