Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --version to print out Packager/Node versions, target platform/arch #841

Merged
merged 1 commit into from May 14, 2018

Conversation

malept
Copy link
Member

@malept malept commented May 13, 2018

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Re-add --version, but this time make it have the behavior that most other CLIs have. If it is given a value, it will print a warning about possible other related flags.

@codecov
Copy link

codecov bot commented May 13, 2018

Codecov Report

Merging #841 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #841   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         622    621    -1     
=====================================
- Hits          622    621    -1
Impacted Files Coverage Δ
index.js 100% <100%> (ø) ⬆️
common.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7b06d9...3ba8d69. Read the comment docs.

@malept malept merged commit a7af94d into master May 14, 2018
@malept malept deleted the cli-version-prints-out-packager-version branch May 14, 2018 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant