Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent trying to download mips64el arch for Electron 2.x #843

Merged
merged 1 commit into from May 14, 2018

Conversation

malept
Copy link
Member

@malept malept commented May 14, 2018

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This fixes all: true and platform:linux + arch: all cases as well.

See also: electron/electronjs.org-old#1252

@codecov
Copy link

codecov bot commented May 14, 2018

Codecov Report

Merging #843 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #843   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         621    621           
=====================================
  Hits          621    621
Impacted Files Coverage Δ
targets.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7af94d...3010573. Read the comment docs.

@malept malept merged commit b3c610c into master May 14, 2018
@malept malept deleted the mips64el-not-supported-by-2.0.0 branch May 14, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant