Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node 4 support #900

Merged
merged 3 commits into from Oct 31, 2018
Merged

Drop Node 4 support #900

merged 3 commits into from Oct 31, 2018

Conversation

malept
Copy link
Member

@malept malept commented Oct 25, 2018

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fixes #815.

@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #900 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #900   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         643    641    -2     
=====================================
- Hits          643    641    -2
Impacted Files Coverage Δ
mac.js 100% <100%> (ø) ⬆️
ignore.js 100% <100%> (ø) ⬆️
infer.js 100% <100%> (ø) ⬆️
platform.js 100% <100%> (ø) ⬆️
win32.js 100% <100%> (ø) ⬆️
common.js 100% <100%> (ø) ⬆️
targets.js 100% <100%> (ø) ⬆️
prune.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b487df2...8ea94db. Read the comment docs.

@malept malept merged commit 3366253 into master Oct 31, 2018
@malept malept deleted the drop-node-4 branch October 31, 2018 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants