Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop callback support #916

Merged
merged 1 commit into from Dec 4, 2018
Merged

Drop callback support #916

merged 1 commit into from Dec 4, 2018

Conversation

malept
Copy link
Member

@malept malept commented Dec 4, 2018

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Removes callback-style support (use nodeify if you need that still), and adds an async/await example to the API docs.

@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #916 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #916   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         671    668    -3     
=====================================
- Hits          671    668    -3
Impacted Files Coverage Δ
index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41bf218...6b7579b. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #916 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #916   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         671    668    -3     
=====================================
- Hits          671    668    -3
Impacted Files Coverage Δ
index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41bf218...6b7579b. Read the comment docs.

@malept malept merged commit a533d5f into master Dec 4, 2018
@malept malept deleted the drop-callback-support branch December 4, 2018 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant