Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure relative out dirs are correctly ignored when copying #919

Merged
merged 4 commits into from Dec 10, 2018

Conversation

malept
Copy link
Member

@malept malept commented Dec 10, 2018

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This happens when both the dir and the out dir are relative to the current working directory.

Fixes #918.

This happens when both the dir and the out dir are relative to the
current working directory.

Fixes #918.
@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #919 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #919   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         668    669    +1     
=====================================
+ Hits          668    669    +1
Impacted Files Coverage Δ
ignore.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e8526a...06ea093. Read the comment docs.

@malept malept merged commit 8d752c2 into master Dec 10, 2018
@malept malept deleted the fix-relative-out-dir-ignore branch December 10, 2018 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant