Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing MSI attempts dual signing and fails #181

Open
AdamPD opened this issue Mar 25, 2024 · 1 comment
Open

Signing MSI attempts dual signing and fails #181

AdamPD opened this issue Mar 25, 2024 · 1 comment

Comments

@AdamPD
Copy link

AdamPD commented Mar 25, 2024

Since the change in #177 to use @electron/windows-sign, the package now tries to dual sign the MSI with both SHA-1 and SHA-256 (which fails):

Error: Signtool exited with code 1. Stderr: SignTool Error: Multiple signature support is not implemented for this filetype.

@electron/windows-sign needs to be able to specify that only a single algorithm is required, and then this package should specify which one to use.

@PeteAUK
Copy link

PeteAUK commented Mar 26, 2024

I've just updated to the latest version of everything and getting exactly the same error. Digging into it and trying a plethora of
approaches and I think this is an issue more relating to windows-sign and MSI's than anything else. I've even tried multiple versions of signtool.exe to see if that made any difference (which it didn't).

On my Windows 10 machine the only way I've got this working is to set appendSignature to false on line 106 of cjs/signWithSignTool.js - it's a hack and not something I'd necessarily recommend. It also explains why the old way of doing it didn't break, because that flag adds the /as argument onto the signtool.exe command which is where the error comes from.

Don't quite know if this varies depending on the operating system being used as it's a weird one to have slipped through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants