Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The setup icon cannot find when build nsis #430

Open
langsz opened this issue Oct 19, 2023 · 0 comments
Open

[Bug] The setup icon cannot find when build nsis #430

langsz opened this issue Oct 19, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@langsz
Copy link

langsz commented Oct 19, 2023

Add icon in electron-builder.json5, it will catch a error cannot find the icon. part of my file:
... directories: { output: 'release/${version}', }, files: ['dist-electron', 'dist'], extraFiles: [ { from: 'vendor', to: 'vendor', filter: ['!**/.git', '!**/.github'], }, ], "win": { "target": [ { "target": "nsis", "arch": [ "x64" ] } ], "artifactName": "${productName}-Windows-${version}-Setup.${ext}", "icon": "public/logo.png" },' ....

there is the error:
Error while loading icon from "H:\xxxxxx\release\1.0.0\.icon-ico\icon.ico": can't open file.

It seems that the .icon-ico only generate in "${version}" directory but not copy to the "1.0.0".

image

@langsz langsz added the bug Something isn't working label Oct 19, 2023
@langsz langsz changed the title [Bug] esbuilder icon cannot find [Bug] The setup icon cannot find when build nsis Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant