From c427ef7b5a01e26bf174e735a2b9bbc4b911b38a Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Tue, 12 Apr 2022 10:34:17 +0200 Subject: [PATCH] fix: look for API LGTM comments too --- src/api-review-state.ts | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/api-review-state.ts b/src/api-review-state.ts index c1f089e..0020d03 100644 --- a/src/api-review-state.ts +++ b/src/api-review-state.ts @@ -104,6 +104,14 @@ export async function addOrUpdateAPIReviewCheck( }) ).data.filter(review => members.includes(review.user.login)); + const comments = ( + await octokit.issues.listComments({ + owner, + repo, + issue_number: pr.number, + }) + ).data.filter(comment => members.includes(comment.user.login)); + // If the PR is semver-patch, it does not need API review. if (!pr.labels.some(l => isSemverMajorMinorLabel(l.name))) { await resetToNeutral(); @@ -111,8 +119,12 @@ export async function addOrUpdateAPIReviewCheck( } const users = { - approved: reviews.filter(review => review.body.match(/API LGTM/gi)).map(r => r.user.login), - declined: reviews.filter(review => review.body.match(/API DECLINED/gi)).map(r => r.user.login), + approved: [...reviews, ...comments] + .filter(item => item.body.match(/API LGTM/gi)) + .map(r => r.user.login), + declined: [...reviews, ...comments] + .filter(item => item.body.match(/API DECLINED/gi)) + .map(r => r.user.login), requestedChanges: reviews .filter(review => review.state === REVIEW_STATUS.CHANGES_REQUESTED) .map(r => r.user.login),