From 10062c9a5b068863da4fc9c8382ec272d1cb74b3 Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Mon, 20 Jun 2022 10:00:10 +0900 Subject: [PATCH] chore: warn when using the deprecated new-window event (#34593) Co-authored-by: Milan Burda --- lib/browser/guest-window-manager.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/browser/guest-window-manager.ts b/lib/browser/guest-window-manager.ts index fb6ae6edf00b0..7aa91a15c9134 100644 --- a/lib/browser/guest-window-manager.ts +++ b/lib/browser/guest-window-manager.ts @@ -5,7 +5,7 @@ * out-of-process (cross-origin) are created here. "Embedder" roughly means * "parent." */ -import { BrowserWindow } from 'electron/main'; +import { BrowserWindow, deprecate } from 'electron/main'; import type { BrowserWindowConstructorOptions, Referrer, WebContents, LoadURLOptions } from 'electron/main'; import { parseFeatures } from '@electron/internal/browser/parse-features-string'; @@ -155,6 +155,10 @@ function emitDeprecatedNewWindowEvent ({ event, embedder, guest, windowOpenArgs, ...parseContentTypeFormat(postData) } : null; + if (embedder.listenerCount('new-window') > 0) { + deprecate.log('The new-window event is deprecated and will be removed. Please use contents.setWindowOpenHandler() instead.'); + } + embedder.emit( 'new-window', event,