From 17c80bb288357ede63208d54b3ef0629e1758246 Mon Sep 17 00:00:00 2001 From: Darshan Sen Date: Thu, 5 May 2022 13:42:50 +0530 Subject: [PATCH] fixup! fix: throw a new exception for safeStorage before app is ready Signed-off-by: Darshan Sen --- shell/browser/api/electron_api_safe_storage.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shell/browser/api/electron_api_safe_storage.cc b/shell/browser/api/electron_api_safe_storage.cc index 7b1b2c6a8d5fb..d0e3a73bcdb0d 100644 --- a/shell/browser/api/electron_api_safe_storage.cc +++ b/shell/browser/api/electron_api_safe_storage.cc @@ -75,7 +75,7 @@ std::string DecryptString(v8::Isolate* isolate, v8::Local buffer) { if (!Browser::Get()->is_ready()) { gin_helper::ErrorThrower(isolate).ThrowError( "safeStorage cannot be used before app is ready"); - return v8::Local(); + return ""; } gin_helper::ErrorThrower(isolate).ThrowError( "Error while decrypting the ciphertext provided to "