From 4c8583c36525b4fe0778eb6585881b6327737802 Mon Sep 17 00:00:00 2001 From: David Sanders Date: Tue, 4 Apr 2023 01:27:51 -0700 Subject: [PATCH] test: remove workaround for fixed Menu.closePopup issue (#37802) --- spec/api-menu-spec.ts | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/spec/api-menu-spec.ts b/spec/api-menu-spec.ts index adf10663d69bd..16c2e4b2df127 100644 --- a/spec/api-menu-spec.ts +++ b/spec/api-menu-spec.ts @@ -817,10 +817,7 @@ describe('Menu module', function () { it('should emit menu-will-close event', (done) => { menu.on('menu-will-close', () => { done(); }); menu.popup({ window: w }); - // https://github.com/electron/electron/issues/19411 - setTimeout().then(() => { - menu.closePopup(); - }); + menu.closePopup(); }); it('returns immediately', () => { @@ -849,18 +846,12 @@ describe('Menu module', function () { expect(x).to.equal(100); expect(y).to.equal(101); - // https://github.com/electron/electron/issues/19411 - setTimeout().then(() => { - menu.closePopup(); - }); + menu.closePopup(); }); it('works with a given BrowserWindow, no options, and a callback', (done) => { menu.popup({ window: w, callback: () => done() }); - // https://github.com/electron/electron/issues/19411 - setTimeout().then(() => { - menu.closePopup(); - }); + menu.closePopup(); }); it('prevents menu from getting garbage-collected when popuping', async () => {