From 4eedea620ff58d23f9571db4c1b4c13428e7a17a Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Thu, 3 Jun 2021 00:02:52 +0200 Subject: [PATCH] test: fix failing iframe test https://github.com/nodejs/node/pull/33021 --- spec-main/api-browser-window-spec.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/spec-main/api-browser-window-spec.ts b/spec-main/api-browser-window-spec.ts index a96c489180133..f51ebff96aa11 100644 --- a/spec-main/api-browser-window-spec.ts +++ b/spec-main/api-browser-window-spec.ts @@ -3660,11 +3660,12 @@ describe('BrowserWindow module', () => { expect(w.webContents.isLoadingMainFrame()).to.be.false('isLoadingMainFrame'); const didStartLoading = emittedOnce(w.webContents, 'did-start-loading'); - w.webContents.executeJavaScript(` + await w.webContents.executeJavaScript(`(() => { var iframe = document.createElement('iframe') iframe.src = '${serverUrl}/page2' document.body.appendChild(iframe) - `); + return null + })()`); await didStartLoading; expect(w.webContents.isLoadingMainFrame()).to.be.false('isLoadingMainFrame');