From 5686a0713e0444508f4c5142dd4399e3f1e2e206 Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Mon, 24 Jun 2019 10:17:38 -0700 Subject: [PATCH] fix: make isDarkMode correctly detect dark mode in the auto setting on catalina (#18949) --- shell/browser/api/atom_api_system_preferences_mac.mm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/shell/browser/api/atom_api_system_preferences_mac.mm b/shell/browser/api/atom_api_system_preferences_mac.mm index 9508e182caf4d..8cd5f7f19476c 100644 --- a/shell/browser/api/atom_api_system_preferences_mac.mm +++ b/shell/browser/api/atom_api_system_preferences_mac.mm @@ -628,6 +628,10 @@ AVMediaType ParseMediaType(const std::string& media_type) { } bool SystemPreferences::IsDarkMode() { + if (@available(macOS 10.14, *)) { + return [[NSApplication sharedApplication].effectiveAppearance.name + isEqualToString:NSAppearanceNameDarkAqua]; + } NSString* mode = [[NSUserDefaults standardUserDefaults] stringForKey:@"AppleInterfaceStyle"]; return [mode isEqualToString:@"Dark"];