From 62eb077f29d78bc76c0e610e08de7de69789ee4c Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Wed, 28 Nov 2018 22:23:41 -0800 Subject: [PATCH] refactor: simplify logic for enabling stack dumping (#15872) ref #15785 --- atom/app/atom_main_delegate.cc | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/atom/app/atom_main_delegate.cc b/atom/app/atom_main_delegate.cc index 722d3e82db8f5..2eb287b0d1572 100644 --- a/atom/app/atom_main_delegate.cc +++ b/atom/app/atom_main_delegate.cc @@ -155,18 +155,9 @@ bool AtomMainDelegate::BasicStartupComplete(int* exit_code) { // Logging with pid and timestamp. logging::SetLogItems(true, false, true, false); - // Enable convient stack printing. -#if defined(DEBUG) && defined(OS_LINUX) - bool enable_stack_dumping = true; -#else - bool enable_stack_dumping = env->HasVar("ELECTRON_ENABLE_STACK_DUMPING"); -#endif -#if defined(ARCH_CPU_ARM_FAMILY) && defined(ARCH_CPU_32_BITS) - // For 32bit ARM enabling stack printing would end up crashing. - // https://github.com/electron/electron/pull/11230#issuecomment-363232482 - enable_stack_dumping = false; -#endif - if (enable_stack_dumping) + // Enable convient stack printing. This is enabled by default in non-official + // builds. + if (env->HasVar("ELECTRON_ENABLE_STACK_DUMPING")) base::debug::EnableInProcessStackDumping(); chrome::RegisterPathProvider();