From 7ee06c354e8560203eb9091bf29716a46c9eeb3c Mon Sep 17 00:00:00 2001
From: "trop[bot]" <trop[bot]@users.noreply.github.com>
Date: Tue, 21 May 2019 16:22:45 +0900
Subject: [PATCH] fix: 'page-title-updated' event forwarding + documentation
 (#18318)

---
 docs/api/browser-window.md        |  2 ++
 docs/api/web-contents.md          | 11 +++++++++++
 lib/browser/api/browser-window.js |  4 ++--
 3 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/docs/api/browser-window.md b/docs/api/browser-window.md
index f57c1dff04067..0755a6cf75c14 100644
--- a/docs/api/browser-window.md
+++ b/docs/api/browser-window.md
@@ -412,9 +412,11 @@ Returns:
 
 * `event` Event
 * `title` String
+* `explicitSet` Boolean
 
 Emitted when the document changed its title, calling `event.preventDefault()`
 will prevent the native window's title from changing.
+`explicitSet` is false when title is synthesized from file url.
 
 #### Event: 'close'
 
diff --git a/docs/api/web-contents.md b/docs/api/web-contents.md
index c552a6015f1d3..ecf232d345054 100644
--- a/docs/api/web-contents.md
+++ b/docs/api/web-contents.md
@@ -101,6 +101,17 @@ Returns:
 
 Emitted when the document in the given frame is loaded.
 
+#### Event: 'page-title-updated'
+
+Returns:
+
+* `event` Event
+* `title` String
+* `explicitSet` Boolean
+
+Fired when page title is set during navigation. `explicitSet` is false when
+title is synthesized from file url.
+
 #### Event: 'page-favicon-updated'
 
 Returns:
diff --git a/lib/browser/api/browser-window.js b/lib/browser/api/browser-window.js
index 3694acd119c99..a35747afe69db 100644
--- a/lib/browser/api/browser-window.js
+++ b/lib/browser/api/browser-window.js
@@ -39,9 +39,9 @@ BrowserWindow.prototype._init = function () {
   })
 
   // Change window title to page title.
-  this.webContents.on('page-title-updated', (event, title) => {
+  this.webContents.on('page-title-updated', (event, title, ...args) => {
     // Route the event to BrowserWindow.
-    this.emit('page-title-updated', event, title)
+    this.emit('page-title-updated', event, title, ...args)
     if (!this.isDestroyed() && !event.defaultPrevented) this.setTitle(title)
   })