From 8517c499e98e3442af60a0d3728cc402379f1556 Mon Sep 17 00:00:00 2001 From: "trop[bot]" Date: Fri, 7 Jun 2019 11:31:39 -0700 Subject: [PATCH] fix: use isEqual instead of pointer equality to convert NSAppearance (#18689) --- atom/browser/api/atom_api_system_preferences_mac.mm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/atom/browser/api/atom_api_system_preferences_mac.mm b/atom/browser/api/atom_api_system_preferences_mac.mm index 7f1513c2215a2..57fef8c297b38 100644 --- a/atom/browser/api/atom_api_system_preferences_mac.mm +++ b/atom/browser/api/atom_api_system_preferences_mac.mm @@ -57,11 +57,11 @@ static bool FromV8(v8::Isolate* isolate, return v8::Null(isolate); } - if (val.name == NSAppearanceNameAqua) { + if ([val.name isEqualToString:NSAppearanceNameAqua]) { return mate::ConvertToV8(isolate, "light"); } if (@available(macOS 10.14, *)) { - if (val.name == NSAppearanceNameDarkAqua) { + if ([val.name isEqualToString:NSAppearanceNameDarkAqua]) { return mate::ConvertToV8(isolate, "dark"); } }