From 880b9bbb536141262b15a20a6ba728c70b2298e1 Mon Sep 17 00:00:00 2001 From: Heilig Benedek Date: Tue, 30 Oct 2018 19:29:42 +0100 Subject: [PATCH] fix: allocate accelerator on the stack --- atom/browser/api/atom_api_menu.cc | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/atom/browser/api/atom_api_menu.cc b/atom/browser/api/atom_api_menu.cc index 393468bec78e3..c378e17f87297 100644 --- a/atom/browser/api/atom_api_menu.cc +++ b/atom/browser/api/atom_api_menu.cc @@ -156,10 +156,9 @@ base::string16 Menu::GetSublabelAt(int index) const { } base::string16 Menu::GetAcceleratorTextAt(int index) const { - auto* accelerator = new ui::Accelerator(); - model_->GetAcceleratorAtWithParams(index, true, accelerator); - - return accelerator ? accelerator->GetShortcutText() : base::string16(); + ui::Accelerator accelerator; + model_->GetAcceleratorAtWithParams(index, true, &accelerator); + return accelerator.GetShortcutText(); } bool Menu::IsItemCheckedAt(int index) const {