From 996d197f97cd1978628730eab00675cf0a5c0c20 Mon Sep 17 00:00:00 2001 From: John Kleinschmidt Date: Wed, 16 Nov 2022 19:52:13 -0500 Subject: [PATCH] src: add detailed embedder process initialization AP https://github.com/nodejs/node/pull/44121 --- shell/app/node_main.cc | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/shell/app/node_main.cc b/shell/app/node_main.cc index f1ef042242435..ce47f744381cb 100644 --- a/shell/app/node_main.cc +++ b/shell/app/node_main.cc @@ -141,12 +141,14 @@ int NodeMain(int argc, char* argv[]) { if (flags_exit_code != 0) exit(flags_exit_code); - node::InitializationSettingsFlags flags = node::kRunPlatformInit; - node::InitializationResult result = - node::InitializeOncePerProcess(argc, argv, flags); + std::unique_ptr result = + node::InitializeOncePerProcess( + std::vector(argv, argv + argc), + {node::ProcessInitializationFlags::kNoInitializeV8, + node::ProcessInitializationFlags::kNoInitializeNodeV8Platform}); - if (result.early_return) - exit(result.exit_code); + if (result->early_return()) + exit(result->exit_code()); gin::V8Initializer::LoadV8Snapshot( gin::V8SnapshotFileType::kWithAdditionalContext); @@ -176,7 +178,7 @@ int NodeMain(int argc, char* argv[]) { uint64_t env_flags = node::EnvironmentFlags::kDefaultFlags | node::EnvironmentFlags::kHideConsoleWindows; env = node::CreateEnvironment( - isolate_data, gin_env.context(), result.args, result.exec_args, + isolate_data, gin_env.context(), result->args(), result->exec_args(), static_cast(env_flags)); CHECK_NE(nullptr, env);