From a9f601612fbac2febff14477825b89ca7c90f63d Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Fri, 7 Jun 2019 09:55:29 -0700 Subject: [PATCH] fix: use isEqual instead of pointer equality to convert NSAppearance (#18665) --- atom/browser/api/atom_api_system_preferences_mac.mm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/atom/browser/api/atom_api_system_preferences_mac.mm b/atom/browser/api/atom_api_system_preferences_mac.mm index 9a2e4a16cec9e..093be869194d9 100644 --- a/atom/browser/api/atom_api_system_preferences_mac.mm +++ b/atom/browser/api/atom_api_system_preferences_mac.mm @@ -66,11 +66,11 @@ static bool FromV8(v8::Isolate* isolate, return v8::Null(isolate); } - if (val.name == NSAppearanceNameAqua) { + if ([val.name isEqualToString:NSAppearanceNameAqua]) { return mate::ConvertToV8(isolate, "light"); } if (@available(macOS 10.14, *)) { - if (val.name == NSAppearanceNameDarkAqua) { + if ([val.name isEqualToString:NSAppearanceNameDarkAqua]) { return mate::ConvertToV8(isolate, "dark"); } }