From b61692d790516246c2f0f37ee648f8e18d79ffc7 Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Mon, 1 Aug 2022 07:42:38 -0700 Subject: [PATCH] fix: remove skip-taskbar feature on Linux. (#35156) * fix: remove skip-taskbar feature on Linux. Marked as unsupported in e19, now removed in e20. See #33226 for more information * docs: remove skipTaskbar note in browserWindow Co-authored-by: Charles Kerr Co-authored-by: Keeley Hammond --- docs/api/browser-window.md | 2 +- shell/browser/native_window_views.cc | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/docs/api/browser-window.md b/docs/api/browser-window.md index d2a4ef468b5e5..e5fd4045803a2 100644 --- a/docs/api/browser-window.md +++ b/docs/api/browser-window.md @@ -1323,7 +1323,7 @@ win.setSheetOffset(toolbarRect.height) Starts or stops flashing the window to attract user's attention. -#### `win.setSkipTaskbar(skip)` +#### `win.setSkipTaskbar(skip)` _macOS_ _Windows_ * `skip` boolean diff --git a/shell/browser/native_window_views.cc b/shell/browser/native_window_views.cc index 51ccfef8c689f..cf26c47e83e78 100644 --- a/shell/browser/native_window_views.cc +++ b/shell/browser/native_window_views.cc @@ -303,14 +303,9 @@ NativeWindowViews::NativeWindowViews(const gin_helper::Dictionary& options, #if defined(USE_OZONE_PLATFORM_X11) if (IsX11()) { - // TODO(ckerr): remove in Electron v20.0.0 // Before the window is mapped the SetWMSpecState can not work, so we have // to manually set the _NET_WM_STATE. std::vector state_atom_list; - bool skip_taskbar = false; - if (options.Get(options::kSkipTaskbar, &skip_taskbar) && skip_taskbar) { - state_atom_list.push_back(x11::GetAtom("_NET_WM_STATE_SKIP_TASKBAR")); - } // Before the window is mapped, there is no SHOW_FULLSCREEN_STATE. if (fullscreen) {