diff --git a/atom/browser/native_window.h b/atom/browser/native_window.h index 651754ef6d5c0..a8b3b1542e66c 100644 --- a/atom/browser/native_window.h +++ b/atom/browser/native_window.h @@ -38,11 +38,6 @@ class Dictionary; class PersistentDictionary; } // namespace mate -namespace appCommand { -const char kBrowserForward[] = "browser-forward"; -const char kBrowserBackward[] = "browser-backward"; -} // namespace appCommand - namespace atom { class AtomMenuModel; diff --git a/atom/browser/native_window_views.cc b/atom/browser/native_window_views.cc index 51445ad89a084..a6db82b5d4ba6 100644 --- a/atom/browser/native_window_views.cc +++ b/atom/browser/native_window_views.cc @@ -22,6 +22,7 @@ #include "atom/browser/web_contents_preferences.h" #include "atom/browser/web_view_manager.h" #include "atom/browser/window_list.h" +#include "atom/common/atom_constants.h" #include "atom/common/draggable_region.h" #include "atom/common/native_mate_converters/image_converter.h" #include "atom/common/options_switches.h" @@ -289,6 +290,7 @@ NativeWindowViews::NativeWindowViews(const mate::Dictionary& options, #endif #if defined(OS_LINUX) + // Listen to move events. aura::Window* window = GetNativeWindow(); if (window) window->AddPreTargetHandler(this); @@ -1288,9 +1290,9 @@ void NativeWindowViews::HandleKeyboardEvent( const content::NativeWebKeyboardEvent& event) { #if defined(OS_LINUX) if (event.windows_key_code == ui::VKEY_BROWSER_BACK) - NotifyWindowExecuteAppCommand(appCommand::kBrowserBackward); - if (event.windows_key_code == ui::VKEY_BROWSER_FORWARD) - NotifyWindowExecuteAppCommand(appCommand::kBrowserForward); + NotifyWindowExecuteAppCommand(kBrowserBackward); + else if (event.windows_key_code == ui::VKEY_BROWSER_FORWARD) + NotifyWindowExecuteAppCommand(kBrowserForward); #endif keyboard_event_handler_->HandleKeyboardEvent(event, @@ -1304,9 +1306,9 @@ void NativeWindowViews::OnMouseEvent(ui::MouseEvent* event) { return; if (event->changed_button_flags() == ui::EF_BACK_MOUSE_BUTTON) - NotifyWindowExecuteAppCommand(appCommand::kBrowserBackward); - if (event->changed_button_flags() == ui::EF_FORWARD_MOUSE_BUTTON) - NotifyWindowExecuteAppCommand(appCommand::kBrowserForward); + NotifyWindowExecuteAppCommand(kBrowserBackward); + else if (event->changed_button_flags() == ui::EF_FORWARD_MOUSE_BUTTON) + NotifyWindowExecuteAppCommand(kBrowserForward); } #endif diff --git a/atom/browser/native_window_views.h b/atom/browser/native_window_views.h index 5b10ec260a186..1d7a096771ecd 100644 --- a/atom/browser/native_window_views.h +++ b/atom/browser/native_window_views.h @@ -206,7 +206,7 @@ class NativeWindowViews : public NativeWindow, const content::NativeWebKeyboardEvent& event) override; #if defined(OS_LINUX) - // EventHandler: + // ui::EventHandler: void OnMouseEvent(ui::MouseEvent* event) override; #endif diff --git a/atom/browser/native_window_views_win.cc b/atom/browser/native_window_views_win.cc index 5114aba87bbd5..65d0ffed18a66 100644 --- a/atom/browser/native_window_views_win.cc +++ b/atom/browser/native_window_views_win.cc @@ -4,6 +4,7 @@ #include "atom/browser/browser.h" #include "atom/browser/native_window_views.h" +#include "atom/common/atom_constants.h" #include "content/public/browser/browser_accessibility_state.h" #include "ui/base/win/accessibility_misc_utils.h" @@ -18,9 +19,9 @@ namespace { const char* AppCommandToString(int command_id) { switch (command_id) { case APPCOMMAND_BROWSER_BACKWARD: - return appCommand::kBrowserBackward; + return kBrowserBackward; case APPCOMMAND_BROWSER_FORWARD: - return appCommand::kBrowserForward; + return kBrowserForward; case APPCOMMAND_BROWSER_REFRESH: return "browser-refresh"; case APPCOMMAND_BROWSER_STOP: diff --git a/atom/common/atom_constants.cc b/atom/common/atom_constants.cc index ad4d25236943a..19b2bde65a01c 100644 --- a/atom/common/atom_constants.cc +++ b/atom/common/atom_constants.cc @@ -6,6 +6,9 @@ namespace atom { +const char kBrowserForward[] = "browser-forward"; +const char kBrowserBackward[] = "browser-backward"; + const char kCORSHeader[] = "Access-Control-Allow-Origin: *"; const char kSHA1Certificate[] = "SHA-1 Certificate"; diff --git a/atom/common/atom_constants.h b/atom/common/atom_constants.h index 93bd592588eec..3b86a2cf90792 100644 --- a/atom/common/atom_constants.h +++ b/atom/common/atom_constants.h @@ -9,6 +9,10 @@ namespace atom { +// The app-command in NativeWindow. +extern const char kBrowserForward[]; +extern const char kBrowserBackward[]; + // Header to ignore CORS. extern const char kCORSHeader[]; diff --git a/docs/api/browser-window.md b/docs/api/browser-window.md index fd9b942605a86..422e252432be2 100644 --- a/docs/api/browser-window.md +++ b/docs/api/browser-window.md @@ -580,7 +580,7 @@ win.on('app-command', (e, cmd) => { }) ``` -The following app commands are explictly supported on Linux +The following app commands are explictly supported on Linux: * `browser-backward` * `browser-forward`