From c94c2f6e3b4da79c1c0c856d1f3961a38fe48f3e Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Wed, 30 Jan 2019 18:54:27 -0800 Subject: [PATCH] retain backwards compatibility --- atom/browser/api/atom_api_top_level_window.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/atom/browser/api/atom_api_top_level_window.cc b/atom/browser/api/atom_api_top_level_window.cc index 45e888a2bc25f..431f120dc1a21 100644 --- a/atom/browser/api/atom_api_top_level_window.cc +++ b/atom/browser/api/atom_api_top_level_window.cc @@ -650,6 +650,9 @@ void TopLevelWindow::SetMenu(v8::Isolate* isolate, v8::Local value) { mate::ConvertFromV8(isolate, value, &menu) && !menu.IsEmpty()) { menu_.Reset(isolate, menu.ToV8()); window_->SetMenu(menu->model()); + } else if (value->IsNull()) { + menu_.Reset(); + window_->SetMenu(nullptr); } else { isolate->ThrowException( v8::Exception::TypeError(mate::StringToV8(isolate, "Invalid Menu")));