From cacebb014b098d82bde4d84dd4c4f12c6409d5bc Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Mon, 29 Apr 2019 14:41:04 -0700 Subject: [PATCH] Update node_debugger.cc --- atom/browser/node_debugger.cc | 5 +---- spec/node-spec.js | 3 ++- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/atom/browser/node_debugger.cc b/atom/browser/node_debugger.cc index 1fb80e3027117..71a06140496fe 100644 --- a/atom/browser/node_debugger.cc +++ b/atom/browser/node_debugger.cc @@ -60,10 +60,7 @@ void NodeDebugger::Start() { void NodeDebugger::Stop() { auto* inspector = env_->inspector_agent(); - if (inspector == nullptr) - return; - - if (inspector->IsListening()) + if (inspector && inspector->IsListening()) inspector->Stop(); } diff --git a/spec/node-spec.js b/spec/node-spec.js index acaa667033ec9..623ecacd2135d 100644 --- a/spec/node-spec.js +++ b/spec/node-spec.js @@ -327,7 +327,8 @@ describe('node feature', () => { }) it('does does not crash when quitting with the inspector connected', function (done) { - this.timeout(240000) + // IPC Electron child process not supported on Windows + if (process.platform === 'win32') return this.skip() child = ChildProcess.spawn(remote.process.execPath, [path.join(__dirname, 'fixtures', 'module', 'delay-exit'), '--inspect=0'], { stdio: ['ipc'] })