From dc979388bacc65f0441e666875010ede8eb70b61 Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Thu, 7 Nov 2019 13:37:14 -0500 Subject: [PATCH] fix: check for validity of guest webcontents (#21035) --- shell/browser/web_view_manager.cc | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/shell/browser/web_view_manager.cc b/shell/browser/web_view_manager.cc index e48ad9cb11f0b..6aa9f81ae9d80 100644 --- a/shell/browser/web_view_manager.cc +++ b/shell/browser/web_view_manager.cc @@ -62,10 +62,14 @@ content::WebContents* WebViewManager::GetGuestByInstanceID( bool WebViewManager::ForEachGuest(content::WebContents* embedder_web_contents, const GuestCallback& callback) { - for (auto& item : web_contents_embedder_map_) - if (item.second.embedder == embedder_web_contents && - callback.Run(item.second.web_contents)) + for (auto& item : web_contents_embedder_map_) { + if (item.second.embedder != embedder_web_contents) + continue; + + auto* guest_web_contents = item.second.web_contents; + if (guest_web_contents && callback.Run(guest_web_contents)) return true; + } return false; }