diff --git a/appveyor.yml b/appveyor.yml index 67d00a69d7e63..123f49f28534a 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -176,17 +176,15 @@ build_script: - 7z a node_headers.zip out\Default\gen\node_headers - ps: >- # Temporarily disable symbol generation on 32-bit Windows due to failures - if (($env:GN_CONFIG -eq 'release') -And ($env:TARGET_ARCH -ne 'ia32')) { + if (($env:GN_CONFIG -eq 'release' -And $env:TARGET_ARCH -ne 'ia32') { # Needed for msdia140.dll on 64-bit windows $env:Path += ";$pwd\third_party\llvm-build\Release+Asserts\bin" ninja -C out/Default electron:electron_symbols } - ps: >- - if ($env:GN_CONFIG -eq 'release') { - if ($env:TARGET_ARCH -ne 'ia32') { - python electron\script\zip-symbols.py - appveyor-retry appveyor PushArtifact out/Default/symbols.zip - } + if (($env:GN_CONFIG -eq 'release' -And $env:TARGET_ARCH -ne 'ia32') { + python electron\script\zip-symbols.py + appveyor-retry appveyor PushArtifact out/Default/symbols.zip } else { # It's useful to have pdb files when debugging testing builds that are # built on CI. diff --git a/script/release/uploaders/upload.py b/script/release/uploaders/upload.py index 014d7c53749b4..c3f860603624a 100755 --- a/script/release/uploaders/upload.py +++ b/script/release/uploaders/upload.py @@ -76,9 +76,10 @@ def main(): shutil.copy2(os.path.join(OUT_DIR, 'dist.zip'), electron_zip) upload_electron(release, electron_zip, args) if get_target_arch() != 'mips64el': - symbols_zip = os.path.join(OUT_DIR, SYMBOLS_NAME) - shutil.copy2(os.path.join(OUT_DIR, 'symbols.zip'), symbols_zip) - upload_electron(release, symbols_zip, args) + if get_target_arch() != 'ia32' and PLATFORM != 'win32': + symbols_zip = os.path.join(OUT_DIR, SYMBOLS_NAME) + shutil.copy2(os.path.join(OUT_DIR, 'symbols.zip'), symbols_zip) + upload_electron(release, symbols_zip, args) if PLATFORM == 'darwin': if get_platform_key() == 'darwin' and get_target_arch() == 'x64': api_path = os.path.join(ELECTRON_DIR, 'electron-api.json') @@ -95,9 +96,10 @@ def main(): shutil.copy2(os.path.join(OUT_DIR, 'dsym-snapshot.zip'), dsym_snaphot_zip) upload_electron(release, dsym_snaphot_zip, args) elif PLATFORM == 'win32': - pdb_zip = os.path.join(OUT_DIR, PDB_NAME) - shutil.copy2(os.path.join(OUT_DIR, 'pdb.zip'), pdb_zip) - upload_electron(release, pdb_zip, args) + if get_target_arch() != 'ia32': + pdb_zip = os.path.join(OUT_DIR, PDB_NAME) + shutil.copy2(os.path.join(OUT_DIR, 'pdb.zip'), pdb_zip) + upload_electron(release, pdb_zip, args) elif PLATFORM == 'linux': debug_zip = os.path.join(OUT_DIR, DEBUG_NAME) shutil.copy2(os.path.join(OUT_DIR, 'debug.zip'), debug_zip)