From e838729de8b99574c240a2daee8d5909b2c118b8 Mon Sep 17 00:00:00 2001 From: sentialx Date: Tue, 7 Apr 2020 01:20:57 +0200 Subject: [PATCH] fix: ProxyWebSocket hitting DCHECK --- shell/browser/electron_browser_client.cc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/shell/browser/electron_browser_client.cc b/shell/browser/electron_browser_client.cc index 2f96d100ea6e9..72e5951f1b803 100644 --- a/shell/browser/electron_browser_client.cc +++ b/shell/browser/electron_browser_client.cc @@ -1356,9 +1356,12 @@ void ElectronBrowserClient::CreateWebSocket( browser_context); DCHECK(web_request_api); - web_request_api->ProxyWebSocket(frame, std::move(factory), url, - site_for_cookies.RepresentativeUrl(), - user_agent, std::move(handshake_client)); + + if (web_request_api->MayHaveProxies()) { + web_request_api->ProxyWebSocket(frame, std::move(factory), url, + site_for_cookies.RepresentativeUrl(), + user_agent, std::move(handshake_client)); + } #endif v8::Isolate* isolate = v8::Isolate::GetCurrent();