From fa2634d1be70b2d213948998efc2c360bbb8c984 Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Wed, 27 May 2020 19:32:08 -0700 Subject: [PATCH] Unconditionally include report feature https://github.com/nodejs/node/pull/32242 --- patches/node/build_add_gn_build_files.patch | 24 ++++++--------------- 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/patches/node/build_add_gn_build_files.patch b/patches/node/build_add_gn_build_files.patch index c9dfe9128e67b..cac0eee07007c 100644 --- a/patches/node/build_add_gn_build_files.patch +++ b/patches/node/build_add_gn_build_files.patch @@ -10,7 +10,7 @@ new file mode 100644 index 0000000000000000000000000000000000000000..d1dcdfeb14994abb07914c2f8e927c67d1b463ab --- /dev/null +++ b/BUILD.gn -@@ -0,0 +1,376 @@ +@@ -0,0 +1,360 @@ +import("//electron/build/asar.gni") +import("//v8/gni/v8.gni") + @@ -18,9 +18,6 @@ index 0000000000000000000000000000000000000000..d1dcdfeb14994abb07914c2f8e927c67 + # Enable the V8 inspector protocol for use with node. + node_enable_inspector = true + -+ # Enable diagnostic reporting withing Node.js -+ node_report = true -+ + # Build node with SSL support. + # The variable is called "openssl" for parity with node's GYP build. + node_use_openssl = true @@ -126,11 +123,6 @@ index 0000000000000000000000000000000000000000..d1dcdfeb14994abb07914c2f8e927c67 + } else { + defines += [ "NODE_USE_V8_PLATFORM=0" ] + } -+ if (node_report) { -+ defines += [ "NODE_REPORT=1" ] -+ } else { -+ defines += [ "NODE_REPORT=0" ] -+ } +} + +config("node_lib_config") { @@ -262,14 +254,6 @@ index 0000000000000000000000000000000000000000..d1dcdfeb14994abb07914c2f8e927c67 + libs += [ "CoreFoundation.framework" ] + } + -+ if (node_report) { -+ sources += [ -+ "src/node_report.cc", -+ "src/node_report_module.cc", -+ "src/node_report_utils.cc", -+ ] -+ } -+ + if (node_enable_inspector) { + sources += [ + "src/inspector_agent.cc", @@ -882,7 +866,7 @@ new file mode 100644 index 0000000000000000000000000000000000000000..eb708f8d5095332b3d860987fa025b23776a37eb --- /dev/null +++ b/filenames.json -@@ -0,0 +1,509 @@ +@@ -0,0 +1,513 @@ +// This file is automatically generated by generate_gn_filenames_json.py +// DO NOT EDIT +{ @@ -1262,6 +1246,9 @@ index 0000000000000000000000000000000000000000..eb708f8d5095332b3d860987fa025b23 + "src/node_process_events.cc", + "src/node_process_methods.cc", + "src/node_process_object.cc", ++ "src/node_report.cc", ++ "src/node_report_module.cc", ++ "src/node_report_utils.cc", + "src/node_serdes.cc", + "src/node_sockaddr.cc", + "src/node_stat_watcher.cc", @@ -1352,6 +1339,7 @@ index 0000000000000000000000000000000000000000..eb708f8d5095332b3d860987fa025b23 + "src/node_perf_common.h", + "src/node_platform.h", + "src/node_process.h", ++ "src/node_report.h", + "src/node_revert.h", + "src/node_root_certs.h", + "src/node_sockaddr.h",