Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpages are too bright #10737

Closed
ghost opened this issue Oct 10, 2017 · 7 comments
Closed

webpages are too bright #10737

ghost opened this issue Oct 10, 2017 · 7 comments
Labels

Comments

@ghost
Copy link

ghost commented Oct 10, 2017

  • Electron version: Latest
  • Operating system: Mac

Expected behavior

Take a look at the following screenshot from chrome.
screen shot 2017-10-10 at 6 11 17 pm

Actual behavior

This is how it appears using electron.
screen shot 2017-10-10 at 6 11 09 pm

How to reproduce

I've noticed this happening in both my custom electron apps, and in other apps that are built on top of electron: The brightness just seems to be higher than on chrome.
But, i've also noticed this issue when using qutebrowser so my guess is that this might be a chromium issue?

@welcome
Copy link

welcome bot commented Oct 10, 2017

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@teleclimber
Copy link
Contributor

This could be the same problem as the bug I filed yesterday: #10732

@ghost
Copy link
Author

ghost commented Oct 12, 2017

It is indeed the same as the bug you filed.
I'm not sure what I can do to help though!

@teleclimber
Copy link
Contributor

teleclimber commented Nov 3, 2017

Actually, I take it back. I think there is something else going on.

screen shot 2017-11-03 at 4 10 10 pm

[edit]On the left is a page rendered in Electron, on the right is same page in Chrome.[/edit]

You'll notice it's only the <pre> and <br> that look significantly different. It turns out these are styled as:

font-family: monospace;

I presume this is the same font as is used to show the XML code in the screenshots above. So the issue appears to have something to do with that font, or the way Chrome renders that font.

Beyond that, I'm not sure.

@sorentycho
Copy link

I suspect this is something similar to #10955 or so.

@sofianguy
Copy link
Contributor

Thank you for taking the time to report this issue and helping to make Electron better.

The version of Electron you reported this on has been superseded by newer releases.

If you're still experiencing this issue in Electron v2.0.x or later, please add a comment specifying the version you're testing with and any other new information that a maintainer trying to reproduce the issue should know.

I'm setting the blocked/need-info label for the above reasons.

Thanks in advance! Your help is appreciated.

@sofianguy sofianguy added the blocked/need-info ❌ Cannot proceed without more information label Jan 7, 2019
@sofianguy
Copy link
Contributor

Thank you for your issue!

We haven't gotten a response to our questions in our comment above. With only the information that is currently in the issue, we don't have enough information to take action. I'm going to close this but don't hesitate to reach out if you have or find the answers we need, we'll be happy to reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants