Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser windows have an extra tab focus which can not be disabled and is not visible #12919

Closed
MRayermannMSFT opened this issue May 14, 2018 · 5 comments

Comments

@MRayermannMSFT
Copy link
Contributor

  • Electron Version: 2.0.0
  • Operating System (Platform and Version): Windows 10
  • Last known working Electron version: N/A

Expected Behavior
If the last focusable HTML element is focused and I press 'tab', then the next thing that is focused should either be the first focusable HTML element, or if not, then whatever is focused should have a visible focus.

Actual behavior
Something is being focused (I think it is the entire HTML document?) and there is no visual indication as to what it is. It is fine that this other thing is being focused, what is not fine is that I/a user does not know where the keyboard focus has gone.

To Reproduce

  • Checkout the electron-quick-start- Put an <input type="text"/> before the renderer.js script
  • Launch quick start
  • Set focus in the input
  • Press 'tab'
@craxal
Copy link

craxal commented Jun 26, 2018

Is there any plan to get this fixed? Or is there a known workaround?

@bpasero
Copy link
Contributor

bpasero commented Jul 12, 2018

From my knowledge of this issue, this has been like that for a very long time and is not a regression from Electron 2.0. Possibly related: https://developers.google.com/web/updates/2016/03/focus-start-point

@craxal
Copy link

craxal commented Jul 12, 2018

Not sure if it is. I'm seeing a Chrome version of 61 for Electron 2.0.0.

We suspect that focus is passing out of the HTML document onto the renderer window itself, since screen readers (sometimes) read out the title bar of the window.

I should add that I've observed this on macOS and Linux as well. It's not just a Windows issue.

@MRayermannMSFT
Copy link
Contributor Author

Ya, it looks like the problem is that Chrome_RenderWidgetHostHWND's are focusable. Based on that name, it sounds like @craxal is correct, and it also makes me think this will require filing against Chromium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants