Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace getProcessMemoryInfo API in chromium 67 #13447

Closed
alexeykuzmin opened this issue Jun 26, 2018 · 4 comments
Closed

Replace getProcessMemoryInfo API in chromium 67 #13447

alexeykuzmin opened this issue Jun 26, 2018 · 4 comments
Labels

Comments

@alexeykuzmin
Copy link
Contributor

alexeykuzmin commented Jun 26, 2018

ProcessMetrics::GetMemoryBytes won't be available after an upgrade to Chromium 67+, see #13383.
But those metrics are quite important, so we should try to find a way to keep them.

/cc @miniak, @juturu, @nitsakh

@alexeykuzmin alexeykuzmin changed the title Keep privateBytes and sharedBytes event after the ProcessMetrics::GetMemoryBytes is not available Keep privateBytes and sharedBytes even after the ProcessMetrics::GetMemoryBytes is not available Jun 26, 2018
@nitsakh
Copy link
Contributor

nitsakh commented Jul 30, 2018

Based on the chromium task (https://bugs.chromium.org/p/chromium/issues/detail?id=819289) and related notes, it looks like the details in the electron getProcessMemoryInfo API response provide results are platform specific and mean different on different platforms. These no longer exist in chromium 67. Chromium has moved to using the memory_instrumentation apis, and that's the recommended cross platform way.
There are ways to get platform specific details (process_metric.h), but if just the memory footprint is needed we can use the private_memory_footprint from the instrumentation API.
(Also updating the issue title to reflect the getProcessMemoryInfo API deprecation)

@nitsakh nitsakh changed the title Keep privateBytes and sharedBytes even after the ProcessMetrics::GetMemoryBytes is not available Replace getProcessMemoryInfo API in chromium 67 Jul 30, 2018
@nitsakh
Copy link
Contributor

nitsakh commented Oct 4, 2018

/cc @electron/reviewers Request your suggestions for the above PR and the API changes.

@bpasero
Copy link
Contributor

bpasero commented Jan 8, 2019

@alexeykuzmin @nitsakh is this still an issue given #14847 landed? I cannot find it in Electron 4.0.x though, so not sure if its 5.0.x only?

@codebytere
Copy link
Member

This is completed and released in 5-0-x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants