Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] Menubar foreground color is styled using context menu foreground color #15575

Closed
sbatten opened this issue Nov 5, 2018 · 2 comments
Closed

Comments

@sbatten
Copy link

sbatten commented Nov 5, 2018

Using VS Code 1.29 insiders on Electron 2.0.12
Ubuntu 18.10 with Yaru GTK3 theme

Expected Behavior
The menubar should have light text with a black background.

Actual behavior
The menubar has dark text on a dark background.

To Reproduce

  1. Install and Run VS Code 1.29 insiders
  2. See dark text on dark background for menubar

Screenshots
If applicable, add screenshots to help explain your problem.

Additional Information
After tweaking the theme css for the Yaru Ubuntu 18.10 theme, it seems the foreground color for the menubar is being pulled from the context menu color, not the menubar foreground color.

The colors are set here:

background_color_ = libgtkui::GetBgColor(menubar_selector);

Related VS Code issue: microsoft/vscode#62593

@joaomoreno
Copy link
Contributor

Duplicate of #15194

@sofianguy
Copy link
Contributor

please follow #15194 for updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants