Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get foreground color from GtkMenuBar#menubar (4-0-x) #16223

Merged
merged 1 commit into from Jan 2, 2019
Merged

fix: get foreground color from GtkMenuBar#menubar (4-0-x) #16223

merged 1 commit into from Jan 2, 2019

Conversation

Cobinja
Copy link

@Cobinja Cobinja commented Dec 31, 2018 •
edited by codebytere

Description of Change

Backport of #15878 to 4-0-x
/cc @inukshuk

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: Fixes incorrect foreground color on GTK menubar

@Cobinja Cobinja requested a review from a team December 31, 2018 13:00
@codebytere codebytere merged commit 5e82efa into electron:4-0-x Jan 2, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 2, 2019

Release Notes Persisted

Fixes incorrect foreground color on GTK menubar

@welcome
Copy link

welcome bot commented Jan 2, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@bengotow bengotow mentioned this pull request Jan 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Cobinja @codebytere