Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: register accelerator if role has no registerAccelerator (backport: 4-0-x) #16314

Merged
merged 2 commits into from Jan 8, 2019
Merged

fix: register accelerator if role has no registerAccelerator (backport: 4-0-x) #16314

merged 2 commits into from Jan 8, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 8, 2019

Backport of #16309

See that PR for details.

Notes: Fixed an issue whereby registerAccelerator was being set to the registerAccelerator property of its role even when registerAccelerator was undefined.

@trop trop bot requested a review from a team January 8, 2019 00:01
@trop trop bot mentioned this pull request Jan 8, 2019
Merged
6 tasks
@trop trop bot added 4-2-x backport This is a backport PR labels Jan 8, 2019
@jkleinsc jkleinsc merged commit 0b6cc93 into electron:4-0-x Jan 8, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 8, 2019

Release Notes Persisted

Fixed an issue whereby registerAccelerator was being set to the registerAccelerator property of its role even when registerAccelerator was undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
4-2-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @jkleinsc