Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The shortcut to close (Ctrl + W) and minimize (Ctrl + M) does not work when it is triggered from the keyboard #16338

Closed
vrbsm opened this issue Jan 9, 2019 · 4 comments

Comments

@vrbsm
Copy link

vrbsm commented Jan 9, 2019

  • Output of node_modules/.bin/electron --version: v4.0.0-beta.8
  • Operating System (Platform and Version): Windows 10

Expected Behavior
When the user trigger Ctrl+W on the keyboard, the application should close and when the user trigger Ctrl+M, the application should minimize.

Actual behavior
When the user trigger Ctrl+W or Ctrl+M on the keyboard nothing happens.

Please see video below to understand better.

To Reproduce

$ git clone https://github.com/vrbsm/electron-quick-start.git -b shortcut-issue
$ npm install
$ npm start || electron .

Screenshots
electron-1003

Additional Information
This feature works in version v4.0.0-beta.7
This feature doesn't work in version v4.0.0 and above

@bpasero
Copy link
Contributor

bpasero commented Jan 10, 2019

I saw the same on 4.0.x where my keybinding for toggling dev tools would no longer work on Windows from an Electron fiddle.

@mathieupothier
Copy link

Same here, I have F5 and Ctrl+F5 menu accelerators and they stopped working when updated to electron 4.0.0 and same goes for 4.0.1 on Windows

@VishwasShashidhar
Copy link

This is probably fixed as part of #16309

@vrbsm
Copy link
Author

vrbsm commented Jan 11, 2019

I am closing this issue because as mentioned above by @VishwasShashidhar, this probably was fixed on #16309
Take a look in #16303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants