fix: emit IPC event in correct context if isolation and sandbox enabled (backport: 4-0-x) #16376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
added 2 commits
January 12, 2019 13:19
IPC events were not being delivered to renderer processes when both `contextIsolation` and `sandbox` were enabled. This is because the `AtomSandboxedRenderFrameObserver` class was incorrectly using the `MainWorldScriptContext`, rather than conditionally selecting the context based on if isolation was enabled. Fixes electron#11922
5 tasks
alexeykuzmin
approved these changes
Jan 12, 2019
miniak
approved these changes
Jan 12, 2019
|
Release Notes Persisted
|
dsabanin
reviewed
Jan 24, 2019
| @@ -116,8 +116,10 @@ class AtomSandboxedRenderFrameObserver : public AtomRenderFrameObserver { | |||
|
|
|||
| auto* isolate = blink::MainThreadIsolate(); | |||
| v8::HandleScope handle_scope(isolate); | |||
| auto context = frame->MainWorldScriptContext(); | |||
|
|
|||
| auto context = renderer_client_->GetContext(frame, isolate); | |||
There was a problem hiding this comment.
This might be creating Cannot get property 'TMPDIR' on missing remote object 59 when trying to access object through electron.remote now.
There was a problem hiding this comment.
@dsabanin This change only landed 12 days ago and has only been released in 5.0. The error you quote there wouldn't be caused by this PR afaik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #16352
See that PR for details.
Notes: Fixed delivery of IPC events to renderer processes when both
contextIsolationandsandboxare enabled.