Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly destroy spellcheck client #16524

Merged
merged 2 commits into from Jan 25, 2019
Merged

fix: correctly destroy spellcheck client #16524

merged 2 commits into from Jan 25, 2019

Conversation

nitsakh
Copy link
Contributor

@nitsakh nitsakh commented Jan 24, 2019 •
edited

Description of Change

Backport of #16448.

Checklist

Release Notes

Notes: Fixed memory leak caused by webFrame.setSpellCheckProvider.

@nitsakh nitsakh requested a review from a team January 24, 2019 06:54
@codebytere codebytere changed the title Fix spellcheck memory leak fix: correctly destroy spellcheck client Jan 24, 2019
@codebytere codebytere added backport This is a backport PR 4-2-x labels Jan 24, 2019
@ckerr ckerr merged commit 0659093 into 4-0-x Jan 25, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 25, 2019

Release Notes Persisted

Fixed memory leak caused by webFrame.setSpellCheckProvider.

@ckerr ckerr deleted the fix-spell-leak-4-0 branch January 25, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
4-2-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nitsakh @deepak1556 @ckerr @codebytere