Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose aes-cfb ciphers from boringssl (backport: 4-0-x) #16617

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jan 30, 2019

Backport of #16573

See that PR for details.

Notes: Restored support for AES-CFB cipher, which was lost when switching from OpenSSL to BoringSSL.

@trop trop bot requested a review from a team January 30, 2019 18:34
@trop trop bot mentioned this pull request Jan 30, 2019
4 tasks
@trop trop bot added 4-2-x backport This is a backport PR labels Jan 30, 2019
@MarshallOfSound
Copy link
Member

AssertionError: value should eventually become the pasted value: expected '' to equal 'test value'

Consistent failure on windows, maybe unrelated but probably slipped through in another PR?

@codebytere codebytere merged commit 28c19da into electron:4-0-x Jan 31, 2019
@release-clerk
Copy link

release-clerk bot commented Jan 31, 2019

Release Notes Persisted

Restored support for AES-CFB cipher, which was lost when switching from OpenSSL to BoringSSL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4-2-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants