Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly handle IPC for promise-based methods #16654

Merged
merged 1 commit into from Feb 5, 2019
Merged

fix: correctly handle IPC for promise-based methods #16654

merged 1 commit into from Feb 5, 2019

Conversation

codebytere
Copy link
Member

Description of Change

Backport of #16433.

cc @MarshallOfSound

Checklist

Release Notes

Notes: Fixed an issue with promise methods not resolving correctly over ipc in the renderer process.

@codebytere codebytere added backport This is a backport PR 4-2-x labels Jan 31, 2019
@codebytere codebytere requested a review from a team January 31, 2019 17:33
@codebytere codebytere changed the title fix: correctly handle IPC for promise-based methods (#16433) fix: correctly handle IPC for promise-based methods Jan 31, 2019
@codebytere codebytere merged commit 0b7680a into 4-0-x Feb 5, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 5, 2019

Release Notes Persisted

Fixed an issue with promise methods not resolving correctly over ipc in the renderer process.

@codebytere codebytere deleted the ipc-passing-async-4 branch February 12, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
4-2-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @MarshallOfSound