fix: use a new Electron dedicated ABI number for Electron 4.0 #16687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
approved these changes
Feb 1, 2019
codebytere
approved these changes
Feb 1, 2019
shiftkey
approved these changes
Feb 2, 2019
|
Release Notes Persisted
|
malept
added a commit
to malept/node-abi
that referenced
this pull request
Feb 3, 2019
malept
added a commit
to malept/node-abi
that referenced
this pull request
Feb 3, 2019
MarshallOfSound
pushed a commit
to electron/node-abi
that referenced
this pull request
Feb 3, 2019
jacobq
added a commit
to jacobq/node
that referenced
this pull request
Apr 24, 2019
`abi_version_registry.json` incorrectly specified that electron v4.0.4 used `NODE_MODULE_VERSION` 64, but in fact it uses 69. See: * electron/electron#16687 * https://github.com/electron/electron/releases/tag/v4.0.4 * electron/node-abi@9e4c1a6
4 tasks
addaleax
pushed a commit
to nodejs/node
that referenced
this pull request
May 19, 2019
`abi_version_registry.json` incorrectly specified that electron v4.0.4 used `NODE_MODULE_VERSION` 64, but in fact it uses 69. See: * electron/electron#16687 * https://github.com/electron/electron/releases/tag/v4.0.4 * electron/node-abi@9e4c1a6 PR-URL: #27394 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
May 20, 2019
`abi_version_registry.json` incorrectly specified that electron v4.0.4 used `NODE_MODULE_VERSION` 64, but in fact it uses 69. See: * electron/electron#16687 * https://github.com/electron/electron/releases/tag/v4.0.4 * electron/node-abi@9e4c1a6 PR-URL: #27394 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the outcome of nodejs/TSC#651 and should fix everyone having issues building / using native modules on Electron 4 with strange ABI mis-match issues.
Brings in: electron/node@8bc5d17
Notes: Change the
NODE_MODULE_VERSIONto 69