Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional remote APIs filtering (backport: 4-0-x) #16688

Merged
merged 1 commit into from Feb 4, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Feb 1, 2019

Description of Change

Backport #16293

Checklist

Release Notes

Notes: Allowed filtering of remote.getBuiltin(), remote.getCurrentWindow(), remote.getCurrentWebContents and <webview>.getWebContents().

@miniak miniak requested review from a team February 1, 2019 22:31
@miniak miniak changed the title feat: add additional remote APIs filtering feat: add additional remote APIs filtering (backport: 4-0-x) Feb 1, 2019
@codebytere
Copy link
Member

Did this already get Kickoff approval?

@miniak
Copy link
Contributor Author

miniak commented Feb 2, 2019

@codebytere Last time it was inconclusive, I will raise it once more on Monday

@miniak miniak self-assigned this Feb 4, 2019
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kickoff Approval

@codebytere codebytere merged commit e253c9b into 4-0-x Feb 4, 2019
@release-clerk
Copy link

release-clerk bot commented Feb 4, 2019

Release Notes Persisted

Allowed filtering of remote.getBuiltin(), remote.getCurrentWindow(), remote.getCurrentWebContents and <webview>.getWebContents().

@codebytere codebytere deleted the miniak/remote-handlers-4.0 branch February 4, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants