Support new nodeIntegrationInSubFrames in webviews

[dansteen]

PR #16425 add support for node integration in iFrames. However this only added support for BrowserWindow (https://electronjs.org/docs/api/browser-window) objects. It would be great if this could be added for webview (https://electronjs.org/docs/api/webview-tag) objects as well!

[dansteen]

In case it helps, we've posted a bounty for this issue: https://www.bountysource.com/issues/70384098-support-new-nodeintegrationinsubframes-in-webviews

We're actually willing to pay more than that (if someone would prefer an hourly rate or something), but didn't want to tie up more than that in bountysource due to fees etc.

[denim2x]

@dansteen Hi - I'd like to get started on this project; can we discuss a small bounty increase?

[dansteen]

@denim2x I have no problem with the requested increase if you feel that that reflects the amount of effort involved.

Looking at your account and commit history I don't see a lot of C/C++ work. Do you have the experience needed to resolve this issue?

[brenca]

Hey @dansteen and @denim2x! If you haven't discussed starting on this, I'd like to take this as well, and I'm more than happy with the bounty.

[dansteen]

Hi @brenca! No problem at all. I'd love to have you start on this.

[mul1sh]

Just seen this issue as well on bounty source, would love to give it a shot @dansteen if it is still open 🙂, the bounty is fine with me and I believe I can turn it around in less than 3 days

Edit

Sorry just seen @brenca's comment, so I'll hold off this issue :)

[brenca]

@dansteen I posted a PR with a fix for this.

[dansteen]

@brenca nice - that's super fast work! I see that it also fixed the other crash as well. That's fantastic!

[dansteen]

hi @brenca Thanks so much for the work you have done on this so far. It looks like things are coming along really nicely!

A quick question. Does the work you have done on this support contextIsolation and partitions?
Thanks!

[brenca]

@dansteen I don't think partitions can cause problems with this, but the tests cover contextIsolation, sandbox and the combination of the two.

[dansteen]

Hi @brenca. Thanks for the superfast turnaround on this it looks great! I'd like to wait to accept the solution until we get a 5x build so we can run a few quick tests. is that ok with you?

[brenca]

@dansteen sure thing! If you want to test before the next 5-0-x release that would contain this gets out, you could also test the testing builds that CI generates when running checks.

[dansteen]

Testing with the output of the CI runs would be just fine @brenca. I see the artifact files for the appvayor builds, but can you point me to the artifacts for the linux builds? Thanks!

[brenca]

Which architecture are you looking for? I can send you a link, I think you need to be an org member to see build artifacts for some reason (for circleci builds anyway)

[dansteen]

amd64 would be fine. Thanks!

[brenca]

@dansteen the latest beta should have the backport included