Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unstable behavior when creating a tabbed window #16925

Closed
shin-kinoshita opened this issue Feb 13, 2019 · 6 comments
Closed

unstable behavior when creating a tabbed window #16925

shin-kinoshita opened this issue Feb 13, 2019 · 6 comments

Comments

@shin-kinoshita
Copy link

  • Electron Version (output of node_modules/.bin/electron --version):
    • v4.0.4
  • Operating System (Platform and Version):
    • macOS 10.14.3
  • Last known working Electron version (if applicable):
    • v3.1.3

Expected Behavior

be created a tabbed window without any stress.

Actual behavior

it actually works but takes few seconds till complete and the tabbed window would be much unstable, especially making it full screen state.

To Reproduce

import { app, BrowserWindow } from 'electron';
app.on('ready', () => {
  const window = new BrowserWindow();
  window.addTabbedWindow(new BrowserWindow());
});

Additional Information

I found that the code works well with electron v3.1.3.

@welcome
Copy link

welcome bot commented Feb 13, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@bpasero
Copy link
Contributor

bpasero commented Feb 24, 2019

@sofianguy I can reproduce in VSCode and would consider this a blocker for us to update to 4.0.x. It looks like any interaction with tabbed windows takes a very long time in Electron 4.

@codebytere
Copy link
Member

Interestingly, this is only true in 4: it's back to normal in v5.0.0 🤔

@zcbenz
Copy link
Member

zcbenz commented May 15, 2019

Some observations:

  1. The addTabbedWindow() call takes usual time;
  2. The CPU usage is normal even though window is lagging;
  3. Using TopLevelWindow instead of BrowserWindow still has the problem.

@bpasero
Copy link
Contributor

bpasero commented May 17, 2019

Confirmed fixed, thanks a lot for the fast turnaround.

@sofianguy
Copy link
Contributor

fixed in #18314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants