Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply setAspectRatio on Window os #17020

Closed
MadfishDT opened this issue Feb 18, 2019 · 3 comments
Closed

apply setAspectRatio on Window os #17020

MadfishDT opened this issue Feb 18, 2019 · 3 comments
Labels
enhancement ✨

Comments

@MadfishDT
Copy link
Contributor

Is your feature request related to a problem? Please describe.
setAspectRatio function not support on Windows OS.

Describe the solution you'd like
on Window OS, Window os native API not support Window Aspect ratio control differenct from MAC OS.
but I tried to make Width/Height ratio operation with WM_SIZE event handler. it was works.

I succeeded stay width - height ratio with aspect_ratio valuable in NativeWindowViews

Describe alternatives you've considered
None

Additional context
@MadfishDT MadfishDT changed the title Apply setAspectRatio Window os apply setAspectRatio on Window os Feb 18, 2019
MadfishDT added a commit to MadfishDT/electron that referenced this issue Mar 6, 2019
@MadfishDT
feat: browser window setaspectratio function activate in windows os (e…
102f4eb 
…lectron#17020)
@MadfishDT
Copy link
Contributor Author

#17245

@MadfishDT
Copy link
Contributor Author

#18306

@ckerr
Copy link
Member

ckerr commented Mar 10, 2022

Duplicate of #8036, fixed by #26941

@ckerr ckerr closed this as completed Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ✨
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ckerr @sofianguy @MadfishDT