Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: access of out-of-scope reference in ShowOpenDialog (backport: 4-0-x) #17176

Merged
merged 1 commit into from Mar 1, 2019
Merged

fix: access of out-of-scope reference in ShowOpenDialog (backport: 4-0-x) #17176

merged 1 commit into from Mar 1, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Feb 28, 2019

Backport of #17126

See that PR for details.

Notes: Fixed a bug when retrieving security scoped bookmarks in ShowOpenDialog and ShowSaveDialog

@jfuechsl @electron-bot
fix: access of out-of-scope reference in ShowOpenDialog and ShowSaveD…
d9fb72e 
…ialog

In the mac file dialog implementation of show*OpenDialog, a settings
object is passed down to the dialog completion handler.
However at the time the completion handler is invoked, the settings
object is already out-of-scope, resulting in an invalid access to
the security_scoped_bookmarks flag.
The fix is to capture the value of the flag and passing that directly
to the completion handler.

fixes issue electron#16664
@trop trop bot requested a review from a team February 28, 2019 21:17
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 28, 2019
@trop trop bot mentioned this pull request Feb 28, 2019
Merged
4 tasks
@trop trop bot added 4-2-x backport This is a backport PR labels Feb 28, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 28, 2019
@codebytere codebytere merged commit 9d30245 into electron:4-0-x Mar 1, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 1, 2019

Release Notes Persisted

Fixed a bug when retrieving security scoped bookmarks in ShowOpenDialog and ShowSaveDialog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
4-2-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @MarshallOfSound @jfuechsl