Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make StreamSubscriber ref counted (backport: 4-1-x) #17267

Merged
merged 1 commit into from Mar 29, 2019
Merged

fix: make StreamSubscriber ref counted (backport: 4-1-x) #17267

merged 1 commit into from Mar 29, 2019

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Mar 7, 2019 •
edited

Description of Change

Backport of #17221

Checklist

Release Notes

Notes: Fix app freeze when using custom stream protocol

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 7, 2019
@trop trop bot mentioned this pull request Mar 7, 2019
Merged
6 tasks
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 8, 2019
@deepak1556
fix: make StreamSubscriber ref counted
1e2adfc 
It is owned by URLRequestStreamJob on the IO thread once request starts,
but if the ownership was abondoned while transfering it to IO thread
which is possible when a request is aborted, then we need to make sure
its destroyed on the right thread to avoid lock in v8.
@deepak1556 deepak1556 changed the base branch from 4-0-x to 4-1-x March 18, 2019 06:22
@deepak1556 deepak1556 changed the title fix: make StreamSubscriber ref counted (backport: 4-0-x) fix: make StreamSubscriber ref counted (backport: 4-1-x) Mar 18, 2019
This was referenced Mar 21, 2019
Closed
Closed
Closed
@pfrazee pfrazee mentioned this pull request Mar 29, 2019
Closed
@jkleinsc jkleinsc requested a review from zcbenz March 29, 2019 14:47
@jkleinsc jkleinsc merged commit 8fd91cc into 4-1-x Mar 29, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 29, 2019

Release Notes Persisted

Fix app freeze when using custom stream protocol

@jkleinsc jkleinsc deleted the stream_crash_4-0-x branch March 29, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deepak1556 @jkleinsc